Skip to content

chore(security): Implement uniform SAST, SCA, and Dependabot#152

Open
gowthamrao wants to merge 25 commits into
developfrom
security-vulnerability
Open

chore(security): Implement uniform SAST, SCA, and Dependabot#152
gowthamrao wants to merge 25 commits into
developfrom
security-vulnerability

Conversation

@gowthamrao
Copy link
Copy Markdown
Contributor

Automated PR to merge security templates

fix: remove implicit admin perms, improve issuer validation, bump v0.…
Greenfield Refactor: Remove legacy transport and enforce strict model…
feat(security): remediate PII leak and update SSRF documentation (#133)
perf: precompile authorization header regex (#142)
Bump minor version to 0.9.0 (#145)
Updates a test comment in `tests/test_logging_enterprise.py` to remove a temporary "VERIFY FIX" marker. The assertion `assert not err` is correct and intended to ensure no duplicate logs appear in stderr when JSON logging is enabled on stdout.

- Removed `VERIFY FIX:` prefix from comment
- Clarified comment to explain the assertion's purpose
- Verified test passes with `pytest tests/test_logging_enterprise.py`
…lient (#148)

Modified `DeviceFlowClient` to use `urllib.parse.urljoin` for constructing the OIDC discovery URL and other endpoints. This improves robustness against trailing slashes in the Identity Provider URL.

Changes:
- Replaced f-string with `urljoin` for `discovery_url`.
- Updated existing `urljoin` calls for consistency and to avoid unnecessary f-strings.
- Verified changes with `ruff` and manual inspection.
- Note: Full test suite execution was skipped due to missing dependencies (`pydantic`) in the sandbox environment.
…nctions (#149)

Refactored `TokenValidator.validate_token` to remove redundant creation of `get_claims_options` and `_decode` nested functions on every call.
- Extracted `_decode` logic to `_decode_token` private method.
- Inlined `claims_options` dictionary creation.

Performance improvement: ~1.7% throughput increase (2901 -> 2950 ops/sec) in micro-benchmark.
Preserves existing functionality and test coverage.
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@gowthamrao gowthamrao changed the base branch from main to develop April 21, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants