Skip to content

Add support for NanoStation loco M900 in model mapping and IeeeMode enumeration#205

Merged
CoMPaTech merged 5 commits intoCoMPaTech:mainfrom
dillten:feature-add-legacy-M900-station
Apr 29, 2026
Merged

Add support for NanoStation loco M900 in model mapping and IeeeMode enumeration#205
CoMPaTech merged 5 commits intoCoMPaTech:mainfrom
dillten:feature-add-legacy-M900-station

Conversation

@dillten
Copy link
Copy Markdown
Contributor

@dillten dillten commented Apr 27, 2026

Adds M900 legacy model to the models list.

Summary by CodeRabbit

  • New Features

    • Adds support for an additional IEEE 802.11n/NG wireless mode.
    • Extends device model recognition to include NanoStation loco M900.
  • Documentation

    • Adds a 0.6.5 changelog entry noting the new device support.
  • Chores

    • Bumps package version to 0.6.5.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Apr 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 42a14ce5-5eb2-410a-9ba4-5b15f4bc25b4

📥 Commits

Reviewing files that changed from the base of the PR and between 88d2137 and 7548d94.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • pyproject.toml
✅ Files skipped from review due to trivial changes (2)
  • CHANGELOG.md
  • pyproject.toml

Walkthrough

Added one new IEEE mode enum member ("11NGHT20") and one manual device model→SKU mapping ("NanoStation loco M900""LocoM900"). Also bumped package version and CHANGELOG entry for the release.

Changes

Cohort / File(s) Summary
IEEE Mode Enumeration
airos/data.py
Added enum member IeeeMode._11NGHT20 = "11NGHT20" to accept the 802.11n/NG HT20 mode literal.
Device Model Mapping
airos/model_map.py
Added manual mapping entry: "NanoStation loco M900""LocoM900" in MANUAL_MODELS.
Release metadata
CHANGELOG.md, pyproject.toml
Added 0.6.5 changelog entry mentioning NanoStation loco M900; updated [project].version from 0.6.40.6.5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • CoMPaTech

Poem

🐰 A tiny enum hop, a model found,
Two lines tucked neatly into the ground,
The loco M900 gives a cheer,
11NGHT20 whispers near,
I nibble code carrots and bound.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding NanoStation loco M900 support to model mapping and extending IeeeMode enumeration with a new mode value.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@airos/model_map.py`:
- Line 88: The dict in model_map contains a key "NanoStation loco M900 " with a
trailing space which causes mismatches in get_sku_by_devmodel and leaks from
get_devmodel_by_sku; remove the stray trailing space from the key so it becomes
"NanoStation loco M900" to restore exact-match O(1) lookups and prevent the
SKU->devmodel getter from returning a padded string, ensuring other sibling keys
(e.g., "NanoStation loco M5") remain unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1ad0f13c-f4ff-49c2-a6f0-25c14cb94c3a

📥 Commits

Reviewing files that changed from the base of the PR and between 1e3cb9a and 72c1446.

📒 Files selected for processing (2)
  • airos/data.py
  • airos/model_map.py

Comment thread airos/model_map.py Outdated
@CoMPaTech
Copy link
Copy Markdown
Owner

Tnx @dillten - just to be sure the 'trailing space' is intended, correct? "NanoStation loco M900 "

@dillten
Copy link
Copy Markdown
Contributor Author

dillten commented Apr 28, 2026

Apologies - no, the trailing space is not intended.

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 28, 2026
@CoMPaTech CoMPaTech requested a review from Copilot April 29, 2026 19:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for the legacy NanoStation loco M900 device by extending model-to-SKU mapping and expanding the IeeeMode enum to recognize the wireless mode reported by v6 XM 900 MHz devices.

Changes:

  • Bump project version to 0.6.5.
  • Add "NanoStation loco M900" -> "LocoM900" to the manual model mapping.
  • Add IeeeMode._11NGHT20 and record the change in CHANGELOG.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
pyproject.toml Version bump for the release containing the new device/mode support.
airos/model_map.py Adds manual model alias mapping for NanoStation loco M900.
airos/data.py Extends IeeeMode enum to include 11NGHT20.
CHANGELOG.md Adds a 0.6.5 changelog entry for the new device support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md Outdated
Comment thread airos/model_map.py
Comment thread airos/data.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@CoMPaTech CoMPaTech merged commit 615c67a into CoMPaTech:main Apr 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants