Add support for NanoStation loco M900 in model mapping and IeeeMode enumeration#205
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
WalkthroughAdded one new IEEE mode enum member ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@airos/model_map.py`:
- Line 88: The dict in model_map contains a key "NanoStation loco M900 " with a
trailing space which causes mismatches in get_sku_by_devmodel and leaks from
get_devmodel_by_sku; remove the stray trailing space from the key so it becomes
"NanoStation loco M900" to restore exact-match O(1) lookups and prevent the
SKU->devmodel getter from returning a padded string, ensuring other sibling keys
(e.g., "NanoStation loco M5") remain unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1ad0f13c-f4ff-49c2-a6f0-25c14cb94c3a
📒 Files selected for processing (2)
airos/data.pyairos/model_map.py
|
Tnx @dillten - just to be sure the 'trailing space' is intended, correct? |
|
Apologies - no, the trailing space is not intended. |
There was a problem hiding this comment.
Pull request overview
Adds support for the legacy NanoStation loco M900 device by extending model-to-SKU mapping and expanding the IeeeMode enum to recognize the wireless mode reported by v6 XM 900 MHz devices.
Changes:
- Bump project version to
0.6.5. - Add
"NanoStation loco M900" -> "LocoM900"to the manual model mapping. - Add
IeeeMode._11NGHT20and record the change inCHANGELOG.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pyproject.toml |
Version bump for the release containing the new device/mode support. |
airos/model_map.py |
Adds manual model alias mapping for NanoStation loco M900. |
airos/data.py |
Extends IeeeMode enum to include 11NGHT20. |
CHANGELOG.md |
Adds a 0.6.5 changelog entry for the new device support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|



Adds M900 legacy model to the models list.
Summary by CodeRabbit
New Features
Documentation
Chores