Skip to content

fix: Duplicate map INI #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexlambson merged 1 commit into from
Feb 3, 2026
Merged

fix: Duplicate map INI #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kirovy/services/cnc_gen_2_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class MapConfigParser(configparser.ConfigParser):

@classmethod
def from_file(cls, file: File) -> "MapConfigParser":
parser = cls()
parser = cls(strict=False)
parser.read_django_file(file)
return parser

Expand Down Expand Up @@ -124,7 +124,7 @@ class CncGen2MapParser:
def __init__(self, uploaded_file: UploadedFile | File):
self.validate_file_type(uploaded_file)
self.file = uploaded_file
self.ini = MapConfigParser()
self.ini = MapConfigParser(strict=False)
self._parse_file()

def _parse_file(self) -> None:
Expand Down
8 changes: 8 additions & 0 deletions tests/fixtures/file_fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,14 @@ def file_map_unfair(load_test_file) -> Generator[File, Any, None]:
file.close()


@pytest.fixture
def file_map_duplicate_ini(load_test_file) -> Generator[File, Any, None]:
"""Return a valid map that has duplicate ini rules."""
file = load_test_file("duplicate_ini.map")
yield file
file.close()


@pytest.fixture
def file_map_dune2k(load_test_file) -> Generator[File, Any, None]:
"""Return a valid zip file for a dune 2k mpa.
Expand Down
Loading