-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add support for Linear desktop app theme injection #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Process name pattern "Linear" causes false-positive process detection
The
process_name_patterns()forAgentKind::Linearreturnsvec!["Linear"], which is a common English word substring. Inagent.rs:27,is_agent_process_runningusespname.contains(p)with an OR against the exe path check (agent.rs:35), so any process whose name contains "Linear" (e.g. "LinearMouse" — a popular macOS mouse utility) would make the function returntrueeven when the actual Linear app isn't running. Unlike "Codex" or "Antigravity" which are distinctive names, "Linear" is a common substring. This causesget_agent_status(lib.rs:81) to report"running": truewhen Linear isn't actually running, confusing users with a "Running" + "No debug port" status. The kill/restart flow is safe (it usesis_agent_bundle_process_runningwhich checks the full exe path), so this is limited to misleading UI status.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.