migrate to gradle#5
Conversation
leonbcode
left a comment
leonbcode
left a comment
There was a problem hiding this comment.
The .gradle directory should be excluded from version control, as it contains files and information that are specific to the Gradle build process and don't need to be tracked by Git.
leonbcode
left a comment
leonbcode
left a comment
There was a problem hiding this comment.
I suggest using the Spring Boot Gradle Plugin as the build plugin, as Spring Boot is already being utilized in the currently used maven build process.
|
I've done some testing and it seems that your changes don't seem to work on my machine at all, either it's a fault on my end, or there are some major flaws in your proposed changes. Now the changes I had to make to get it working:
Hence the migration from Maven to Gradle is a major change regarding the project structure, I'd recommend to address this change in a future meeting. |
|
which gradle task did you (want to) run? |
|
and why did you have to remove the plugins? |
The Spring Boot Gradle Plugin has packaging and dependency management capabilities on it's own and can work as a replacement for the other plugins. (https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/htmlsingle/#introduction) |
bootRun and bootJar, now with the changes in 04f2447 it seems to work. |
| <logger name="main.main.system.eventSystem" level="INFO" /> | ||
| <logger name="main.main.system.commandSystem" level="INFO" /> | ||
| <logger name="main.main.system.commandSystem.CommandProcessor.Chat" level="DEBUG"/> | ||
| <logger name="main.main.system.ASCIIProgressbar" level="INFO" /> |
There was a problem hiding this comment.
here should be main. instead of main.main.
|
Generally I would not recommend a package with the name |
|
We can do that, I would only suggest keeping the nesting to a minimum because I am not a fan of deep nesting |
leonbcode
left a comment
leonbcode
left a comment
There was a problem hiding this comment.
I suggest we wait with the merge until, we as a team have decided on a project name, as the package name should be related to the project name.
| private static Set<Method> scanForSubscriber() { | ||
| // Reflections reflections = new Reflections("main.modules", Scanners.MethodsAnnotated); | ||
| Reflections reflections = new Reflections(new ConfigurationBuilder().forPackages("main.modules").addScanners(Scanners.MethodsAnnotated)); | ||
| // Reflections reflections = new Reflections("main.main.modules", Scanners.MethodsAnnotated); |
There was a problem hiding this comment.
use main.modules instead of main.main.modules
|
|
||
| private static Set<Method> scanForHooks() { | ||
| Reflections reflections = new Reflections(new ConfigurationBuilder().forPackages("main.modules").addScanners(Scanners.MethodsAnnotated)); | ||
| Reflections reflections = new Reflections(new ConfigurationBuilder().forPackages("main.main.modules").addScanners(Scanners.MethodsAnnotated)); |
There was a problem hiding this comment.
use main.modules instead of main.main.modules
| @@ -1,4 +1,4 @@ | |||
| package main.inputs.Twitch4J; | |||
| package main.Twitch4J; | |||
There was a problem hiding this comment.
Twitch4J should be a submodule of inputs, as there will be added more inputs, for example TipeeeStream.
There was a problem hiding this comment.
Yeah, please keep the original folder structure intact.
All Inputs should be in the Inputs directory and implement the TwitchBotInput Interface.
More generally, if someone has questions about implementing something, like me. Then I know what I should include in the wiki articles (that I'm going to write when I have time for that)
3 participants
Gradle > Maven