Conversation
|
Thanks @Astabol, please remove the comments you have introduced, since your changes are self-explanatory |
|
Sure. I shall remove. Thanks |
|
Hello @deRemo, I removed the comments. Thank You |
|
Thanks @Astabol, but please squash the commits into one for a cleaner git history I generally use More info: https://garrytrinder.github.io/2020/03/squashing-commits-using-interactive-rebase |
|
Hi @deRemo , I squashed the commits to single. Thank You |
There was a problem hiding this comment.
Is this required for issue #205? I'd rather not touch the base simulation engine: I'm pretty sure that we want the simulator to fail if getIncomingEvents() is null-pointer, rather than "hiding" it
There was a problem hiding this comment.
Sure. I understand.
There was a problem hiding this comment.
As my comment below, I'm not sure that hiding the nullpointer is the right approach. When calling getCurrentRequestedMips we basically assume that the Vm has been placed, hence getHost() shouldn't be null. I believe that the issue to be fixed is more intricate than this...
There was a problem hiding this comment.
Yeah, it is not fixing the root cause. If anyone called this from another example might get the same issue. I will look into it. Thank You
Hello @qwsdl , This is the fixed for Fixed Issue #205.

Thank You