Skip to content

Conversation

@almahmoud
Copy link
Collaborator

@almahmoud almahmoud commented Jun 21, 2022

{% endif %}
parameters:
availability: melbourne-qh2
availability: nova
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we parameterize this?

- https://raw.githubusercontent.com/kubernetes/cloud-provider-openstack/master/manifests/controller-manager/openstack-cloud-controller-manager-ds.yaml
- https://raw.githubusercontent.com/kubernetes/cloud-provider-openstack/master/manifests/controller-manager/cloud-controller-manager-roles.yaml
- https://raw.githubusercontent.com/kubernetes/cloud-provider-openstack/master/manifests/controller-manager/cloud-controller-manager-role-bindings.yaml
- https://gist.githubusercontent.com/almahmoud/b02942eb2b18ea14123e163e069a79e2/raw/b59139b17d697c9075ce3870ad7e88c567851d8a/openstack-ds.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the custom gist needed? Can we check this in somewhere, maybe into the cloudman-boot repo itself?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The control-plane vs master change for the daemonset node selector was the main issue. The custom gist was to make it work with 1.19 as before. With 1.24, the newer one from their repo works, but the patch under needs to change, and helm versions (notably for nginx) need to be upgraded. This was the easiest way to get it working in the meantime

path: /etc/rancher/node/password
state: present
timeout: 180
timeout: 1800
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half an hour for the password seems a fairly long time. Does it take that long?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did on JS1 on TACC, this is an old change

kube_cloud_conf: "{{ lookup('env', 'KUBE_CLOUD_CONF') | b64decode }}"
# Whether to use the in-tree cloud provider or external cloud-provider
kube_in_tree_provider: true
kube_in_tree_provider: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break the other clouds? Did you check the csi drivers as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSI drivers work for openstack JS2. Haven't looked at other clouds, but I also imagine they're a lot less needed given they have k8s services, so at least personally I think I'm only using this stack for JS

@nuwang
Copy link
Contributor

nuwang commented Jun 27, 2022

I didn't have access to the bioconductor source branch, so I merged this separately.

@nuwang nuwang closed this Jun 27, 2022
@LiNk-NY LiNk-NY deleted the master branch March 15, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants