-
Notifications
You must be signed in to change notification settings - Fork 7
[WIP] JS2 support #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| {% endif %} | ||
| parameters: | ||
| availability: melbourne-qh2 | ||
| availability: nova |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we parameterize this?
| - https://raw.githubusercontent.com/kubernetes/cloud-provider-openstack/master/manifests/controller-manager/openstack-cloud-controller-manager-ds.yaml | ||
| - https://raw.githubusercontent.com/kubernetes/cloud-provider-openstack/master/manifests/controller-manager/cloud-controller-manager-roles.yaml | ||
| - https://raw.githubusercontent.com/kubernetes/cloud-provider-openstack/master/manifests/controller-manager/cloud-controller-manager-role-bindings.yaml | ||
| - https://gist.githubusercontent.com/almahmoud/b02942eb2b18ea14123e163e069a79e2/raw/b59139b17d697c9075ce3870ad7e88c567851d8a/openstack-ds.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the custom gist needed? Can we check this in somewhere, maybe into the cloudman-boot repo itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The control-plane vs master change for the daemonset node selector was the main issue. The custom gist was to make it work with 1.19 as before. With 1.24, the newer one from their repo works, but the patch under needs to change, and helm versions (notably for nginx) need to be upgraded. This was the easiest way to get it working in the meantime
| path: /etc/rancher/node/password | ||
| state: present | ||
| timeout: 180 | ||
| timeout: 1800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Half an hour for the password seems a fairly long time. Does it take that long?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did on JS1 on TACC, this is an old change
| kube_cloud_conf: "{{ lookup('env', 'KUBE_CLOUD_CONF') | b64decode }}" | ||
| # Whether to use the in-tree cloud provider or external cloud-provider | ||
| kube_in_tree_provider: true | ||
| kube_in_tree_provider: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this break the other clouds? Did you check the csi drivers as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSI drivers work for openstack JS2. Haven't looked at other clouds, but I also imagine they're a lot less needed given they have k8s services, so at least personally I think I'm only using this stack for JS
|
I didn't have access to the bioconductor source branch, so I merged this separately. |
Friends with galaxyproject/cloudlaunch#260 CloudVE/cloudbridge#297 CloudVE/djcloudbridge#10