feat: add configurable port binding address for dockerized services #1829
+66
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using Docker with bridge or custom networks, services need explicit port bindings to be accessible. Currently there's no way to configure the bind address for these port mappings.
Modification
portBindAddressfield toDockerConfigurationAUTO_PORT_BIND_ADDRESSconstant for automatic resolution from service host addressDockerizedServicethat binds TCP/UDP ports when not using host network modenodeHostOverridecopy in the configuration builderResult
Users can now configure
portBindAddressin their docker configuration:"auto"to resolve from the service's host addressnullto disable port bindings (current behavior)