Refactor buffer management and update configuration handling#456
Draft
KeithWiles wants to merge 3 commits intoCloudNativeDataPlane:mainfrom
Draft
Refactor buffer management and update configuration handling#456KeithWiles wants to merge 3 commits intoCloudNativeDataPlane:mainfrom
KeithWiles wants to merge 3 commits intoCloudNativeDataPlane:mainfrom
Conversation
Contributor
KeithWiles
commented
Feb 24, 2026
- Added support for unaligned buffers in the buffer management structure.
- Renamed buffer management functions and updated their signatures to use mbuf_t for better type safety.
- Updated the parsing of JSON configuration to include a new option for unaligned buffers.
- Changed the handling of buffer sizes and headroom to improve clarity and consistency.
- Modified the xskdev interface to accommodate the new buffer management structure and functions.
- Improved error handling and logging for buffer management operations.
- The uintr file needs '-mtls-dialect-gnu2' to build the uintr_handler.c file.
397eaa6 to
5333e40
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Added support for unaligned buffers in the buffer management structure. - Renamed buffer management functions and updated their signatures to use mbuf_t for better type safety. - Updated the parsing of JSON configuration to include a new option for unaligned buffers. - Changed the handling of buffer sizes and headroom to improve clarity and consistency. - Modified the xskdev interface to accommodate the new buffer management structure and functions. - Improved error handling and logging for buffer management operations. - The uintr file needs '-mtls-dialect-gnu2' to build the uintr_handler.c file. Signed-off-by: Keith Wiles <keith.wiles@intel.com>
c744c8a to
d1fcbf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.