fix return value of computeCloud2CloudDistance#129
Merged
dgirardeau merged 1 commit intoCloudCompare:masterfrom May 1, 2026
Merged
fix return value of computeCloud2CloudDistance#129dgirardeau merged 1 commit intoCloudCompare:masterfrom
dgirardeau merged 1 commit intoCloudCompare:masterfrom
Conversation
tmontaigu
force-pushed
the
fix-computeDist-return
branch
from
aa8219b to
6524d87
Compare
dgirardeau
reviewed
Apr 25, 2026
Member
dgirardeau
left a comment
dgirardeau
left a comment
There was a problem hiding this comment.
Good catch. I see that most of the call to computeCloud2CloudDistances don't check the return value against DISTANCE_COMPUTATION_RESULTS::SUCCESS anyway (they simply compare it ti 0).
Can you fix the calls to computeCloud2CloudDistances in CCCoreLib at least in this PR? (mostly in RegistrationTools.cpp I believe)
tmontaigu
force-pushed
the
fix-computeDist-return
branch
from
6524d87 to
1bcc359
Compare
dgirardeau
approved these changes
Apr 27, 2026
Contributor
Author
|
I was thinking that maybe we can make the SUCCESS value be 0 and not 1 |
Member
|
That would make sense in terms of consistency with the old code. |
It did not normalize to RESULTS::sucess and the document about it was incorrect
tmontaigu
force-pushed
the
fix-computeDist-return
branch
from
1bcc359 to
74ea6e1
Compare
dgirardeau
approved these changes
Apr 28, 2026
Contributor
Author
|
(I don't have the rights to merge on this repo) |
Member
|
I'll update things on CC's side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It did not normalize to RESULTS::sucess
and the document about it was incorrect
From a check in CC it does not seems like this will break anything