Skip to content

Assert on queue layout #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vadimskipin merged 1 commit into from
May 6, 2026
Merged

Assert on queue layout #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions include/silk/util/bounded-queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,20 @@ class BoundedQueue

static_assert(sizeof(Slot) == CACHELINE_SIZE);

// Match offsets and stride used by src/gdb/fiber.py::_walk_bounded_queue
static_assert(offsetof(Slot, sequence) == 0);
static_assert(offsetof(Slot, value) == 8);

//
// State.
//

uint64_t mask;
std::unique_ptr<Slot[]> slots;

// src/gdb/fiber.py::_walk_bounded_queue reads enqueuePos at offset 64 and
// dequeuePos at offset 128 (mask=8 bytes, slots=8 bytes, then 2 x cacheline).
// Reordering or inserting fields here requires updating that script.
alignas(CACHELINE_SIZE) std::atomic<uint64_t> enqueuePos{};
alignas(CACHELINE_SIZE) std::atomic<uint64_t> dequeuePos{};
};
Expand Down
4 changes: 4 additions & 0 deletions include/silk/util/queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ class QueueBase

static_assert(sizeof(QueueNode) == CACHELINE_SIZE);

// Match offsets used by src/gdb/fiber.py::_walk_queue
static_assert(offsetof(QueueNode, next) == 8);
static_assert(offsetof(QueueNode, value) == 16);

static void initialize() noexcept;
static void destroy() noexcept;

Expand Down
Loading