Add extractAllGroups{Horizontal,Vertical}, regexpQuoteMeta, splitByRegexp#16
Open
Add extractAllGroups{Horizontal,Vertical}, regexpQuoteMeta, splitByRegexp#16
Conversation
theory
approved these changes
May 7, 2026
Comment on lines
+211
to
+221
| static Datum | ||
| span_to_text_datum(re2_span s) | ||
| { | ||
| return PointerGetDatum(span_to_text(s)); | ||
| } | ||
|
|
||
| static Datum | ||
| span_to_bytea_datum(re2_span s) | ||
| { | ||
| return PointerGetDatum(span_to_bytea(s)); | ||
| } |
Contributor
There was a problem hiding this comment.
Why not just use the existing functions? These wrappers seem superfluous.
Comment on lines
+262
to
+265
| * Escape regex metacharacters per ClickHouse semantics: | ||
| * \0 \\ | ( ) ^ $ . [ ] ? * + { : - | ||
| * (Slightly differs from re2::RE2::QuoteMeta which uses \xNN for control bytes.) | ||
| */ |
Contributor
There was a problem hiding this comment.
Link to ClickHouse source to simplify updating later?
| return arr; | ||
| } | ||
|
|
||
| static ArrayType * |
| (1 row) | ||
|
|
||
| -- extractallgroups errors | ||
| \set ON_ERROR_STOP off |
Contributor
There was a problem hiding this comment.
Shouldn't be necessary; pg_regress doesn't set this.
| sed -e 's/[[:space:]]*"version":[[:space:]]*"\([^"]*\)",\{0,1\}/\1/') | ||
|
|
||
| DATA = sql/$(EXTENSION)--$(EXTVERSION).sql | ||
| DATA = $(sort $(wildcard sql/$(EXTENSION)--*.sql)) |
Contributor
There was a problem hiding this comment.
I don't think these need to be sorted, do they?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@theory pointed out some missed functions