Skip to content

Fix nav scripts: remove dead interceptors, debounce observer, scope n…#261

Open
Blargian wants to merge 1 commit into
mainfrom
fix-nav-scripts
Open

Fix nav scripts: remove dead interceptors, debounce observer, scope n…#261
Blargian wants to merge 1 commit into
mainfrom
fix-nav-scripts

Conversation

@Blargian

Copy link
Copy Markdown
Member

…avbar hide

  • ask-ai-button.js: remove capture-phase click/mousedown/keydown interceptors for Mintlify native search ('Can you tell me about') since we replaced native search with Inkeep

  • tab-nav.js: debounce MutationObserver via RAF so rapid React re-renders batch into one flush instead of thrashing main thread with repeated querySelectorAll calls

  • styles.css: scope navbar opacity-hide to .ch-homepage only so SPA page navigation doesn't trigger the fade-in on every page

…avbar hide

- ask-ai-button.js: remove capture-phase click/mousedown/keydown
  interceptors for Mintlify native search ('Can you tell me about')
  since we replaced native search with Inkeep

- tab-nav.js: debounce MutationObserver via RAF so rapid React
  re-renders batch into one flush instead of thrashing main thread
  with repeated querySelectorAll calls

- styles.css: scope navbar opacity-hide to .ch-homepage only so
  SPA page navigation doesn't trigger the fade-in on every page

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 208f6fb. Configure here.

patchTabButtons();
styleDropdownHeaders();
markNavbarReady();
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delayed homepage class causes flicker

Medium Severity

The mutation observer now runs applyHomepageClass inside a debounced requestAnimationFrame, but navbar opacity hiding is scoped to .ch-homepage. Client-side route changes can paint at least one frame where the URL and ch-homepage disagree, so the homepage navbar may flash visible or stay hidden on the wrong page.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 208f6fb. Configure here.

@mintlify

mintlify Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
ClickHouse-docs 🟢 Ready View Preview Jun 24, 2026, 7:25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant