feat: add label disk_name for table metrics#94
Merged
Conversation
Added label disk_name for table metrics. Useful with tiered storage. Bumped golang version to 1.24 since it doesn't even build on 1.23 even before my changes Signed-off-by: Rafał Kozłowski <rafalkozlowski07@gmail.com>
|
|
Collaborator
|
Which ClickHouse server version do you use? did you read https://clickhouse.com/docs/integrations/prometheus ? Why do you need separate exporter? |
Contributor
Author
|
24.8 and currently upgrading to 25.8. I read about this exporter built in in server here but in my case it would be much work to transfer everything since i have many nodes and clusters and new metrics seems to be different than in old exporter. Also i didn't find there metrics related to tables/databases usage. Please tell me if i am wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added label disk_name for table metrics #93.
Useful with tiered storage.
Bumped golang version to 1.24 since it doesn't even build on 1.23 even before my changes