feat: putting changes#91
Closed
silwyne wants to merge 1 commit into
Closed
Conversation
|
smh_tabatabaei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Slach
reviewed
Jun 3, 2025
Slach
left a comment
Slach
left a comment
Collaborator
There was a problem hiding this comment.
fix CI/CD failures and explain why your changes is needed?
| @@ -1,4 +1,4 @@ | |||
| # Clickhouse Exporter for Prometheus (old clickhouse-server versions) | |||
| # Clickhouse Exporter for Prometheus | |||
Collaborator
There was a problem hiding this comment.
do you know about embedded prometheus endpoint in clickhouse-server?
look details https://clickhouse.com/docs/operations/server-configuration-parameters/settings#prometheus
this project was released for old clickhouse-server versions which not have prometheus endpoints
| clickhouse: | ||
| image: clickhouse/clickhouse-server | ||
| clickhouse-exporter: | ||
| image: clickhouse-exporter:0.1.1 |
Collaborator
There was a problem hiding this comment.
this image have no sense, we used clickhouse-server for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.