Deprecate Abseil-backed 128-bit value APIs#531
Merged
Conversation
Add conditional deprecation warnings for public APIs that pass, return, or expose Int128/UInt128 values when clickhouse-cpp is built with CH_USE_ABSEIL_FOR_BIGNUM enabled. The Int128/UInt128 aliases themselves are not deprecated to avoid warnings for plain declarations. Instead, warnings are emitted at value-facing API use sites, including Bignum helpers, Decimal Int128 accessors, Type::CreateSimple specializations, and ColumnVector<Int128>/ColumnVector<UInt128> value accessors. Users can opt into the future non-Abseil implementation with: -DCH_USE_ABSEIL_FOR_BIGNUM=OFF
chernser
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add conditional deprecation warnings for public APIs that pass, return, or expose Int128/UInt128 values when clickhouse-cpp is built with CH_USE_ABSEIL_FOR_BIGNUM enabled.
The Int128/UInt128 aliases themselves are not deprecated to avoid warnings for plain declarations. Instead, warnings are emitted at value-facing API use sites, including Bignum helpers, Decimal Int128 accessors, Type::CreateSimple specializations, and ColumnVector/ColumnVector value accessors.
Users can opt into the future non-Abseil implementation with: -DCH_USE_ABSEIL_FOR_BIGNUM=OFF