Skip to content

Commit 7bdc11f

Browse files
authored
Removed Append(const char*) overload
Users should call string_view overload instead.
1 parent 70d3329 commit 7bdc11f

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

clickhouse/columns/string.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -208,15 +208,6 @@ void ColumnString::Append(std::string&& steal_value) {
208208
items_.emplace_back(std::string_view{ last_data.data(),last_data.length() });
209209
}
210210

211-
void ColumnString::Append(const char* str) {
212-
auto len = strlen(str);
213-
if (blocks_.size() == 0 || blocks_.back().GetAvailable() < len) {
214-
blocks_.emplace_back(std::max(DEFAULT_BLOCK_SIZE, len));
215-
}
216-
217-
items_.emplace_back(blocks_.back().AppendUnsafe(str));
218-
}
219-
220211
void ColumnString::AppendNoManagedLifetime(std::string_view str) {
221212
items_.emplace_back(str);
222213
}

0 commit comments

Comments
 (0)