|
5 | 5 |
|
6 | 6 | namespace { |
7 | 7 |
|
| 8 | +constexpr size_t DEFAULT_BLOCK_SIZE = 4096; |
| 9 | + |
8 | 10 | template <typename Container> |
9 | | -size_t ComputeTotalSize(const Container & strings, size_t begin = 0, size_t len = -1) |
10 | | -{ |
| 11 | +size_t ComputeTotalSize(const Container & strings, size_t begin = 0, size_t len = -1) { |
11 | 12 | size_t result = 0; |
12 | 13 | if (begin < strings.size()) { |
13 | 14 | len = std::min(len, strings.size() - begin); |
@@ -63,8 +64,7 @@ std::string_view ColumnFixedString::operator [](size_t n) const { |
63 | 64 | return std::string_view(&data_[pos], string_size_); |
64 | 65 | } |
65 | 66 |
|
66 | | -size_t ColumnFixedString::FixedSize() const |
67 | | -{ |
| 67 | +size_t ColumnFixedString::FixedSize() const { |
68 | 68 | return string_size_; |
69 | 69 | } |
70 | 70 |
|
@@ -202,30 +202,26 @@ void ColumnString::Append(std::string_view str) { |
202 | 202 | items_.emplace_back(blocks_.back().AppendUnsafe(str)); |
203 | 203 | } |
204 | 204 |
|
205 | | -void ColumnString::Append(std::string&& steal_value) |
206 | | -{ |
| 205 | +void ColumnString::Append(std::string&& steal_value) { |
207 | 206 | append_data_.emplace_back(std::move(steal_value)); |
208 | 207 | auto& last_data = append_data_.back(); |
209 | 208 | items_.emplace_back(std::string_view{ last_data.data(),last_data.length() }); |
210 | 209 | } |
211 | 210 |
|
212 | 211 | void ColumnString::Append(const char* str) { |
213 | 212 | auto len = strlen(str); |
214 | | - if (blocks_.size() == 0 || blocks_.back().GetAvailable() < len) |
215 | | - { |
| 213 | + if (blocks_.size() == 0 || blocks_.back().GetAvailable() < len) { |
216 | 214 | blocks_.emplace_back(std::max(DEFAULT_BLOCK_SIZE, len)); |
217 | 215 | } |
218 | 216 |
|
219 | 217 | items_.emplace_back(blocks_.back().AppendUnsafe(str)); |
220 | 218 | } |
221 | 219 |
|
222 | | -void ColumnString::AppendNoManagedLifetime(std::string_view str) |
223 | | -{ |
| 220 | +void ColumnString::AppendNoManagedLifetime(std::string_view str) { |
224 | 221 | items_.emplace_back(str); |
225 | 222 | } |
226 | 223 |
|
227 | | -void ColumnString::AppendUnsafe(std::string_view str) |
228 | | -{ |
| 224 | +void ColumnString::AppendUnsafe(std::string_view str) { |
229 | 225 | items_.emplace_back(blocks_.back().AppendUnsafe(str)); |
230 | 226 | } |
231 | 227 |
|
|
0 commit comments