Skip to content

chore(storybook): 🤖 add a story to show Table overflow mode set to wrap#936

Merged
punkbit merged 1 commit intomainfrom
chore/add-story-for-table-overflow-mode-wrap
Mar 19, 2026
Merged

chore(storybook): 🤖 add a story to show Table overflow mode set to wrap#936
punkbit merged 1 commit intomainfrom
chore/add-story-for-table-overflow-mode-wrap

Conversation

@punkbit
Copy link
Collaborator

@punkbit punkbit commented Mar 19, 2026

Why?

Add a Storybook story to show Table overflow mode set to "wrap".

How?

  • Add a new story

Preview?

Screenshot 2026-03-19 at 16 55 03

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2026

⚠️ No Changeset found

Latest commit: 345dab5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Mar 19, 2026

Claude finished @punkbit's task in 37s —— View job


Code Review

Nice addition! The story demonstrates the wrap overflow mode well. One issue to fix before merging:

🚨 Must Fix

  • rowsLongTextWrap (line 140): row-1 has overflowMode: 'truncated' instead of 'wrap'. This is inconsistent with the story's purpose — the first row silently falls back to truncated behavior, which may confuse readers comparing rows. Fix this →

💡 Suggestions (non-blocking)

  • The LongTextWrap story render function is identical to LongText, LongTextTruncated, and LongTextTruncatedMiddle (sorting logic, same layout). Consider extracting a shared SortableTableStory render helper to reduce duplication across these four stories.
  • row-4 applies overflowMode: 'wrap' to 'data.csv' — a very short label that will never actually wrap. Consider using a long label there too so the wrap effect is visible on all rows.

@workflow-authentication-public
Copy link
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-iqipavcfi-clickhouse.vercel.app

Built from commit: c1e408331d63869abcc4f5f64e1b545abefb11b8

@punkbit punkbit requested a review from crisalbu March 19, 2026 17:01
@punkbit punkbit merged commit c759e59 into main Mar 19, 2026
10 checks passed
@punkbit punkbit deleted the chore/add-story-for-table-overflow-mode-wrap branch March 19, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants