Skip to content

Add triangle inequality limiter option to nonequilibrium parcel example#591

Closed
oalcabes wants to merge 4 commits intomainfrom
oa/noneq_parcel_limiter_tests
Closed

Add triangle inequality limiter option to nonequilibrium parcel example#591
oalcabes wants to merge 4 commits intomainfrom
oa/noneq_parcel_limiter_tests

Conversation

@oalcabes
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (1afcc6b) to head (580d6b9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   92.65%   92.75%   +0.09%     
==========================================
  Files          47       47              
  Lines        1756     1752       -4     
==========================================
- Hits         1627     1625       -2     
+ Misses        129      127       -2     
Components Coverage Δ
src 94.08% <100.00%> (+0.10%) ⬆️
ext 69.79% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oalcabes oalcabes force-pushed the oa/noneq_parcel_limiter_tests branch from b1c0782 to af79b16 Compare June 16, 2025 23:57
@oalcabes oalcabes marked this pull request as ready for review June 16, 2025 23:57
@oalcabes oalcabes force-pushed the oa/noneq_parcel_limiter_tests branch from 38a2eec to 8fe267c Compare June 17, 2025 00:04
@oalcabes oalcabes added Parcel NonEq 💧🧊 Non equilibrium microphysics Needs review Please review my pull request labels Jun 17, 2025
@trontrytel
Copy link
Copy Markdown
Member

Would it be possible to make all the tendencies in parcel be limited when limiter is set to true? We could use it to test when removing all the q > 0 inside CM.jl?

@oalcabes
Copy link
Copy Markdown
Member Author

Would it be possible to make all the tendencies in parcel be limited when limiter is set to true? We could use it to test when removing all the q > 0 inside CM.jl?

sure -- in all of the examples as well I guess?

@trontrytel
Copy link
Copy Markdown
Member

Would it be possible to make all the tendencies in parcel be limited when limiter is set to true? We could use it to test when removing all the q > 0 inside CM.jl?

sure -- in all of the examples as well I guess?

Yes, but I think you would just need to modify the ParcelTendencies file to do it?

@oalcabes oalcabes force-pushed the oa/noneq_parcel_limiter_tests branch from 8fe267c to 937bf60 Compare June 23, 2025 22:04
@oalcabes oalcabes marked this pull request as draft June 24, 2025 00:16
@oalcabes oalcabes force-pushed the oa/noneq_parcel_limiter_tests branch 2 times, most recently from 937bf60 to 6d32200 Compare June 24, 2025 00:58
@oalcabes oalcabes force-pushed the oa/noneq_parcel_limiter_tests branch from 6d32200 to 580d6b9 Compare June 24, 2025 17:52
return q / dt / n
end

# the triangle inequality limiter used in ClimaAtmos
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# Using same limiter as ClimaAtmos for now
# Using same limiter as ClimaAtmos
if limiter
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If running without the limiter we probably still want to keep the logic of

if qᵥ + qᵢ > FT(0) 
  do stuff
else
  return 0
end

@trontrytel
Copy link
Copy Markdown
Member

the tests that you are adding seem very repetetive NonEq_Tests_dt.jl‎, NonEq_Tests_S0.jl‎, NonEq_Tests_Tau.jl‎, NonEq_Tests_w.jl. Could this be one file with four loops over for different things that are changed but one generic initial condition?

Also, are you planning to include the plots somewhere in the documentation?

@oalcabes
Copy link
Copy Markdown
Member Author

the tests that you are adding seem very repetetive NonEq_Tests_dt.jl‎, NonEq_Tests_S0.jl‎, NonEq_Tests_Tau.jl‎, NonEq_Tests_w.jl. Could this be one file with four loops over for different things that are changed but one generic initial condition?

Also, are you planning to include the plots somewhere in the documentation?

Oops this is a very old PR that I am not actually trying to work on I just was cleaning up my code a couple days ago and pushed to this branch. Sorry didn't realize it was open, not sure it makes sense to actually merge any of it

@trontrytel trontrytel closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review Please review my pull request NonEq 💧🧊 Non equilibrium microphysics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants