Add triangle inequality limiter option to nonequilibrium parcel example#591
Add triangle inequality limiter option to nonequilibrium parcel example#591
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
==========================================
+ Coverage 92.65% 92.75% +0.09%
==========================================
Files 47 47
Lines 1756 1752 -4
==========================================
- Hits 1627 1625 -2
+ Misses 129 127 -2
🚀 New features to boost your workflow:
|
b1c0782 to
af79b16
Compare
38a2eec to
8fe267c
Compare
|
Would it be possible to make all the tendencies in parcel be limited when limiter is set to true? We could use it to test when removing all the |
sure -- in all of the examples as well I guess? |
Yes, but I think you would just need to modify the |
8fe267c to
937bf60
Compare
937bf60 to
6d32200
Compare
6d32200 to
580d6b9
Compare
| return q / dt / n | ||
| end | ||
|
|
||
| # the triangle inequality limiter used in ClimaAtmos |
There was a problem hiding this comment.
Could you add this limiter here:
https://github.com/CliMA/CloudMicrophysics.jl/blob/main/src/Utilities.jl
|
|
||
| # Using same limiter as ClimaAtmos for now | ||
| # Using same limiter as ClimaAtmos | ||
| if limiter |
There was a problem hiding this comment.
If running without the limiter we probably still want to keep the logic of
if qᵥ + qᵢ > FT(0)
do stuff
else
return 0
end
|
the tests that you are adding seem very repetetive Also, are you planning to include the plots somewhere in the documentation? |
Oops this is a very old PR that I am not actually trying to work on I just was cleaning up my code a couple days ago and pushed to this branch. Sorry didn't realize it was open, not sure it makes sense to actually merge any of it |
No description provided.