Conversation
miton18
force-pushed
the
feat/addon-logs
branch
3 times, most recently
from
f289aa1 to
405c96b
Compare
miton18
force-pushed
the
feat/addon-logs
branch
from
ffeff3e to
b3b2bdc
Compare
|
🔎 A preview has been automatically published! If you created the alias to the preview script, you can run this command to download and install this preview: clever-preview update feat-addon-logsYou can also run it from your local repository: ./scripts/preview.js update feat-addon-logs
This preview will be deleted once this PR is closed. |
miton18
force-pushed
the
feat/addon-logs
branch
2 times, most recently
from
d1d370e to
0e441bd
Compare
davlgd
reviewed
Oct 1, 2025
Comment on lines
+26
to
+27
| const addonId = await resolveRealId(addonIdOrRealId); | ||
| const ownerId = await resolveOwnerId(addonId); |
Contributor
There was a problem hiding this comment.
Maybe findAddonsByNameOrId() can help here
Member
There was a problem hiding this comment.
We never supported add-on names in this commande. Let's stick to IDs for now.
miton18
force-pushed
the
feat/addon-logs
branch
from
0e441bd to
3afa6f7
Compare
Contributor
Author
|
up |
|
@miton18 do you need the second item (feature flag) to be complete before merging it? |
Member
|
Closing in favor of #1032 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: