Flare 1823 : legacy graceful shutdown handling#519
Open
Conversation
swadkumar
requested review from
andruwm and
jakegut
and removed request for
a team
andruwm
reviewed
Sep 4, 2025
andruwm
requested changes
Sep 4, 2025
Contributor
andruwm
left a comment
andruwm
left a comment
There was a problem hiding this comment.
Left a comment explaining
andruwm
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clever Coding Standards Agreement
JIRA
Link to JIRA
Overview
Flare was caused due to regression in ALB fargate integration causing a flurry of 502s across multiple Clever services.
This was narrowed down to change in Fargate behavior post Aug 27
This PR adds a timeout to WAG shutdown behavior handling so that we can flip to legacy spot termination behavior if required
Testing
Load test is in progress to confirm that the increased timeout helps
Rollout
This gets implemented as a wag pre-release
Rollback
(specific steps? risks?)