Skip to content

Unused err #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
taylor-sutton wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Unused err #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2801df
Check returned error of ioutil.ReadAll
taylor-sutton Nov 1, 2021
c18fe5f
Regenerate samples.
taylor-sutton Nov 1, 2021
87bee4c
Bump version.
taylor-sutton Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
v8.1.1
v8.1.2

v8.1.2: Check the return value of reading the request body.

v8.1.1: Revert update of open-api spec dependency bump

Expand Down
3 changes: 3 additions & 0 deletions samples/gen-go-nils/server/handlers.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions samples/gen-go/server/handlers.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions server/genserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,9 @@ type bodyParamTemplate struct {
var bodyParamTemplateStr = `
{{ if not .IsBinary }}
data, err := ioutil.ReadAll(r.Body)
if err != nil {
return nil, fmt.Errorf("reading request body: %%w", err)
}
{{if .Required}} if len(data) == 0 {
return nil, errors.New("request body is required, but was empty")
}{{end}}
Expand Down