Skip to content

enhance Pyrotech compat #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
WaitingIdly wants to merge 13 commits into
base: master
Choose a base branch
from
Open

enhance Pyrotech compat #366

WaitingIdly wants to merge 13 commits into from

Conversation

@WaitingIdly
Copy link
Collaborator

@WaitingIdly WaitingIdly commented Dec 24, 2025

changes in this PR (description from #333):

  • Fix game crash when Pyrotech modules are disabled.
  • Fix broken examples and remove unnecessary
  • Add integration for missing machines (sawmills, crucibles and Mechanical Compacting Bin)
  • Add recipe inheritance. Inherited recipes get added to more advanced machines.
  • Add and change examples for recipe inheritance.

differences from prior PR:

  • add missing lang keys.
  • add missing annotations and annotations that indicated fields that dont exist.
  • some intellij warnings about unneeded casting, instanceof pattern casts, and potentially confusing field references.
  • some changes to example generation from changes to master since this was forked.

related to #333

CaliforniaDemise and others added 13 commits December 24, 2025 00:35
@CaliforniaDemise @WaitingIdly
Check if module exists before applying Pyrotech recipe registry.
94b6129 
- Fixes CleanroomMC#318
@CaliforniaDemise @WaitingIdly
Fix Pyrotech examples.
bbfcaba 
Some machines can't have inputs with stack sizes larger than one.
@CaliforniaDemise @WaitingIdly
Update examples, add inheritance and add support for missing machines.
0a62e58 
- Update examples to show inheritance.
- Add inheritance. Inherited recipe will be added to the machines more advanced than the machine.
- Add support for missing machines: sawmills, crucibles and Mechanical Compacting Bin.
@CaliforniaDemise @WaitingIdly
Check modules before adding inherited recipes.
db99d38
@CaliforniaDemise @WaitingIdly
Check for 0 in Pyrotech recipe builder properties.
e9f6754
@CaliforniaDemise @WaitingIdly
Remove unnecessary input amount sets.
8b2eb4d
@CaliforniaDemise @WaitingIdly
Change ForgeRegistryWrapper for checking disabled modules.
393a0a6
@CaliforniaDemise @WaitingIdly
Add missing wiki pages and translations. Add notes for inheritance.
1b48a38
@CaliforniaDemise @WaitingIdly
Add support for Bloomery, Wither Forge, Worktable and Pit Burning.
1058701
@CaliforniaDemise @WaitingIdly
Inline and sort.
f52dc84
@CaliforniaDemise @WaitingIdly
Add missing annotations and change other forgotten stuff.
0f861ef
@CaliforniaDemise @WaitingIdly
Change Wither Forge and Bloomery support
6d9afd2
@WaitingIdly
address reviews, intellij warnings, and logged issues
3c55912
@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

mod compat Relating to compatability with a mod or features of a mod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WaitingIdly @CaliforniaDemise