refactor: Change lwjglx handling#561
Open
kappa-maintainer wants to merge 28 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old approach: Merge
org.lwjglxclasses with those fromorg.lwjglhaving same name, so everyone just need to referenceorg.lwjglNew approach: Use
org.lwjglxin Cleanroom and new Cleanroom mods, old mods will be remapped toorg.lwjglx. Classes loaded from jar withLwjgl3-Awaremanifest will be excluded from remap, classes loaded from file will be ignored too.This PR also changed package name of cleanroom to a more standard package.modid path.
This can help to compile against lwjglx class and lwjgl class with same fqcn after merging, which is critical for future development.