Send external_ip config property to clients#1375
Open
Unnvaldr wants to merge 1 commit intoClassicOldSong:masterfrom
Open
Send external_ip config property to clients#1375Unnvaldr wants to merge 1 commit intoClassicOldSong:masterfrom
Unnvaldr wants to merge 1 commit intoClassicOldSong:masterfrom
Conversation
Owner
|
Are there clients supporting this field right now? |
Author
|
Moonlight based clients have usages for this external IP, but by default it is empty and as a result, ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
There is no mechanism that determines the external IP address of the machine, which is crucial especially for computers behind VPN/NAT. Sending the manually set external IP address to the client, will allow for the machine to be discoverable in local and remote scenarios.
What Changed
Addition of an additional JSON property
root.ExternalIPto the Nvidia GameStream's protocol, that reflects the server's configexternal_ipproperty value.Impact
No change in behaviour on the server's side; clients will have one additonal endpoint to check at discovery and to send to for WoL packets.