Open
Conversation
Removed references to external server to pick up person_source_value (this isn't anywhere in the person table in latest (mimic-iii v1.4)) Changed csv file open to start with .gz file (what is provided from physionet.org site for mimic-iii) Changed solr_url to match localhost install Small updates to progress print() statements to clarify progress (out of total rows) and HTTP response (200)
add'l tweaks after realizing some elements were hard to understand/hard-coded
code wasn't handling remaining rows/posting to server; this was fixed also made user parameter for document source more obvious and next to other user parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed references to external server to pick up person_source_value (this isn't anywhere in the person table in latest (mimic-iii v1.4))
Changed csv file open to start with .gz file (what is provided from physionet.org site for mimic-iii)
Changed solr_url to match localhost install
Fixed issues where remaining rows beyond last full chunk weren't getting posted to solr
Small updates to progress print() statements to clarify progress (out of total rows) and HTTP response (200)