Skip to content

add dest to scoreboard#868

Merged
okx-code merged 7 commits intoCivMC:mainfrom
Huskydog9988:dest-on-scoreboard
Apr 20, 2026
Merged

add dest to scoreboard#868
okx-code merged 7 commits intoCivMC:mainfrom
Huskydog9988:dest-on-scoreboard

Conversation

@Huskydog9988
Copy link
Copy Markdown
Contributor

@Huskydog9988 Huskydog9988 commented Oct 12, 2025

fixes #835

@Metriximor
Copy link
Copy Markdown
Contributor

Every time I set a dest I look at the scoreboard. Intuitively this is something that belongs there, nice work!

Copy link
Copy Markdown
Contributor

@okx-code okx-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destination display setting doesn't work

@Huskydog9988 Huskydog9988 requested a review from okx-code January 7, 2026 23:47
Copy link
Copy Markdown
Contributor

@okx-code okx-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I change the destination setting visibility it doesn't actually disappear from the sidebar? Did you test this?

Also fixed issue where registered listeners would be called before new value is set
@Huskydog9988 Huskydog9988 requested a review from okx-code April 3, 2026 01:33
Copy link
Copy Markdown
Contributor

@okx-code okx-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I relog the destination disappears from the sidebar

@Huskydog9988 Huskydog9988 requested a review from okx-code April 19, 2026 23:44
@okx-code okx-code merged commit e96b662 into CivMC:main Apr 20, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Ready for Release in CivMC Roadmap Apr 20, 2026
@Huskydog9988 Huskydog9988 deleted the dest-on-scoreboard branch April 20, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Release

Development

Successfully merging this pull request may close these issues.

add your dest to the scoreboard

3 participants