Added support for colors in Geojson layers + Option to use free map tiles#5
Merged
amcarrero merged 2 commits intoCityScope:mainfrom Mar 6, 2025
Merged
Added support for colors in Geojson layers + Option to use free map tiles#5amcarrero merged 2 commits intoCityScope:mainfrom
amcarrero merged 2 commits intoCityScope:mainfrom
Conversation
amcarrero
requested changes
Feb 24, 2025
Collaborator
amcarrero
left a comment
amcarrero
left a comment
There was a problem hiding this comment.
Thanks for the PR! I’ve added some comments addressing certain parts of the code
Contributor
Author
|
Did the requested changes, I'll later open an issue to discuss a more general solution to selecting the map tiles source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for colors inside geojson layers. If a geojson layer now has properties.color defined for a feature, that color will be used. The format is either a 6 or 8 digit hex.
Also made it so that if the usefreemap=true query parameter is present, the tilelayer will use a free map instead of the default one. This is usefull if anybody wants to run it localy or if the mapbox token changes