-
Notifications
You must be signed in to change notification settings - Fork 6
Bugs/de778 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cis-havana
Are you sure you want to change the base?
Bugs/de778 #5
Conversation
…e the logic where if a user fails authentication in ldap, it will default the SQL driver for authentication. Specifically it addresses - bug in conf definition StrOpts v/s ListOpts for built-in users configuration paramter - Heat templates using cfn-signal where dynamic users are created by keystone - Consolidate the hybrid driver used between nimbus and telstra codebase Rally-bug: DE778 (Admin can create non-buildin user without checking LDAP via Keystone Hybrid Driver) Upstream: False
The patch cleans up config parameter proliferation for hybrid driver to enable isolation of the hybrid driver code. All parameters related to hybrid are not part of the driver code itself. Rally-bug: None (forward-looking enhancement for Icehouse / RHEL supportability Upstream: False
|
Re-defined builtin_user param from StrOpt to ListOpt |
|
+1 good job |
|
Can we add some unit tests ? |
|
Will do |
|
Any update on this? |
|
I've tested this functionality in London was able to successfully add a user that did not exist in either LDAP or built_in users to keystone and provide access to a tenant project. keystone user-create --name cloud_user2 --pass NfEQHTsV --email someuser@somedomain.com [root@csx-a-keystonectl-001 backends]# keystone user-role-add --user cloud_user2 --role Member --tenant HomeWrecker228 [root@csx-a-keystonectl-001 backends]# keystone user-list --tenant HomeWrecker228 I think this code should be merged in and retro fitted to all sites so that we can get away from the need to add local users through the 'built_in' method |
|
@jadelester this code is not a bug fix but a feature. Once @schoksey addresses the peer review in the PR we can work on merging it. However, #8 solves the bug that was originally reported. |
The fix is a clean up of the hybrid driver to simplify and consolidates the driver code.
Specifically it addresses
Rally-bug: DE778 (Admin can create non-buildin user without checking LDAP via Keystone Hybrid Driver)
Upstream: False