Open
Conversation
allenrobel
reviewed
Jan 13, 2026
Collaborator
There was a problem hiding this comment.
This looks fine to me. The only minor points would be:
- We might want to add integration test for xconnect.
- Since there is no 4.x version check around xconnect, what happens when xconnect is specified in a playbook task and run against ND 3.x?
I know adding unit tests would be difficult due to the way UT are structured for the dcnm_network module, so I'm fine with not adding to or modifying unit tests.
I will leave it to @mikewiebe to approve.
Thank you!
dc3ff84 to
f955d9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #604
Add xconnect for ND 4.1: