Skip to content

Fix signup error handling and improve dialog for existing email#521

Open
hiraljj05 wants to merge 1 commit intoCircuitVerse:masterfrom
hiraljj05:fix/signup-dialog-errors-clean
Open

Fix signup error handling and improve dialog for existing email#521
hiraljj05 wants to merge 1 commit intoCircuitVerse:masterfrom
hiraljj05:fix/signup-dialog-errors-clean

Conversation

@hiraljj05
Copy link
Copy Markdown

@hiraljj05 hiraljj05 commented Mar 3, 2026

Fixes #508

Describe the changes you have made in this PR -

  • Fixed the signup button so it responds correctly when clicked.
  • Added proper dialogs for signup success and error messages instead of using snackbars.
  • Handled the case when an email is already registered with a clear error dialog.
  • Prevented LateInitializationError from GetX snackbars by removing snackbar usage.
  • Dismisses keyboard automatically on form submission.
  • Maintains form state properly; resets only for errors other than “email already exists.”

Screenshots of the changes (If any) -
image

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Summary by CodeRabbit

  • Chores
    • Updated Git configuration to exclude additional sensitive files from version control.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 3, 2026

Deploy Preview for cv-mobile-app-web ready!

Name Link
🔨 Latest commit b78c571
🔍 Latest deploy log https://app.netlify.com/projects/cv-mobile-app-web/deploys/69a6d818390f3700084fe19f
😎 Deploy Preview https://deploy-preview-521--cv-mobile-app-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 3, 2026

Walkthrough

This pull request modifies the .gitignore configuration file to adjust Android-related ignore patterns. The change reformats the /android/app/release entry and adds android/app/google-services.json to the list of ignored files. The google-services.json file is a Firebase/Google Cloud configuration file that typically contains sensitive credentials and should not be committed to version control. Net result is two lines added and one removed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The .gitignore changes (adding android/app/google-services.json) appear unrelated to the signup error handling objectives in issue #508. Remove the .gitignore changes or move them to a separate pull request focused on configuration/build changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title mentions fixing signup error handling and improving dialog for existing email, which aligns with the main objective of issue #508 to display error messages for duplicate emails.
Linked Issues check ✅ Passed The PR addresses issue #508 by implementing clear error dialogs for existing emails, proper form state management, and replacing snackbars with dialogs for better user feedback.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.gitignore (1)

46-46: Use a root-anchored path for consistency.

Other Android entries here are root-anchored (/android/...), so consider aligning this one too.

Suggested diff
-android/app/google-services.json
+/android/app/google-services.json

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f621531 and b78c571.

📒 Files selected for processing (1)
  • .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No Error Message Displayed When Signing Up With an Existing Email

1 participant