Skip to content

Comments

New event: Entity (ENTITY=zombie)#35

Open
MrBenjaminBowman wants to merge 6 commits intoCircuitLord:masterfrom
MrBenjaminBowman:entitytag
Open

New event: Entity (ENTITY=zombie)#35
MrBenjaminBowman wants to merge 6 commits intoCircuitLord:masterfrom
MrBenjaminBowman:entitytag

Conversation

@MrBenjaminBowman
Copy link
Contributor

Hello! This adds a tag to the config similar to "BIOME=xxxx", specified as "ENTITY=xxxx". This was inspired by #26 . This allows custom music events for different mob entities. Implementation may need to be tweaked, as some mobs such as Ender Dragon you'd want to detect from much further away. In the future, could maybe be made configurable like "ENTITY=zombie, 100" to look for the mob in a different radius, or maybe for the number of mobs of a certain kind (like Villager).

Please try out and let me know what you think!

@CircuitLord
Copy link
Owner

cool thanks will take a look at this later!

@CircuitLord
Copy link
Owner

CircuitLord commented Dec 7, 2024

checked the code, I think this makes sense! The one thing I'd like to do at some point but haven't figured out how is to be able to configure the radius/mob count like you mentioned, I'm not sure if I should just keep adding stuff to the main entry string or if there needs to be some way to add properties to the entry

just lmk if you're ready to merge it wasn't sure if you wanted to add anything else

@CircuitLord CircuitLord marked this pull request as ready for review December 7, 2024 19:06
@MrBenjaminBowman
Copy link
Contributor Author

as it is it should be good to merge, it can be modified further in the future. I experimented a bit in another branch here with entity distance/nbt, but wasn't quite sure where in SongPicker to add the logic for those. There's probably a much cleaner way to do this if we can access minecraft's Target Selector arguments like is used in commands, but I don't know enough about it 😅

if events keep getting more complex with conditions/arguments, it might make sense to unify the events into some kind of object as to not have to juggle between the strings, lists, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants