Skip to content

Travel To Bruno Mars #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Christopher-Willis wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Travel To Bruno Mars #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b6e78c
Major componates finished
Christopher-Willis Nov 8, 2018
efb2cc1
cleaned up code and added minor comments
Christopher-Willis Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion 05week/spaceTravelToMars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,35 @@ let jobTypes = {
programmer: 'Any Ship!'
};

// Your code here
class CrewMember{
constructor(name,job,specialSkill){
this.name = name;
this.job = job;
this.specialSkill=specialSkill;
this.ship = null;
}
enterShip (myShip){
this.ship = myShip;
// assign new ship pointer to ship object in crew object
myShip.crew.push(this)
Copy link

@ericbarrs ericbarrs Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're pushing the entire class into the crew array.

// create cicular reference to crew member object in ship
}
}
class Ship{
constructor(name,type,ability){
this.name=name;
this.type=type;
this.ability=ability;
this.crew = [];
}
missionStatement(){
if(this.crew.length>0) return this.ability
else return "Can't perform a mission yet."
// need crew memember to perform any function of the mission
}
}


Copy link

@ericbarrs ericbarrs Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make a instance of the crewMember and the Ship,
then you should have the crewMember enter ship.


//tests
if (typeof describe === 'function'){
Expand Down