-
Notifications
You must be signed in to change notification settings - Fork 0
fix: 이미지 벨리데이션 #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 이미지 벨리데이션 #142
Conversation
WalkthroughThe changes expand the allowed file types for image uploads in three controller files by updating the regular expressions used in file type validation. Previously, the validators only permitted specific image MIME types such as jpeg, png, gif, webp, and jpg. The new regex patterns now also accept any MIME type that matches Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/game-builder/game/application/controllers/game.controller.ts (1)
118-118: Expanded image validation to accept any image MIME typeThe regex for file type validation was updated to accept any MIME type that starts with
image/in addition to the explicitly listed formats. This change makes the application more flexible for users uploading images in various formats.For consistency, consider updating the comment above (line 116) from "jpeg와 png, gif 허용" to include the fact that all image types are now allowed.
src/game-builder/page/application/controllers/page.controller.ts (1)
164-164: Expanded image validation to accept any image MIME typeThe file type validation regex now allows any MIME type that starts with
image/, making the application more flexible for users uploading various image formats.For consistency, consider updating the comment above (line 162) from "jpeg와 png, gif 허용" to reflect that all image types are now allowed.
src/user/application/user.controller.ts (1)
138-138: Expanded image validation to accept any image MIME typeThe file type validation regex was updated to accept any MIME type that starts with
image/in addition to the explicitly listed formats, providing more flexibility for user profile image uploads.For consistency with the implementation change, consider updating the documentation comment on line 117 which currently states "이미지파일은 jpeg, png, gif 형식만 허용합니다" (Image files are allowed only in jpeg, png, gif format).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/game-builder/game/application/controllers/game.controller.ts(1 hunks)src/game-builder/page/application/controllers/page.controller.ts(1 hunks)src/user/application/user.controller.ts(1 hunks)
체크리스트
설명
Summary by CodeRabbit