Draft
Conversation
…arekit into share-target # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements comprehensive share target functionality, enabling the application to receive shared content from other applications across Windows, iOS, and macOS platforms.
Key Changes:
- Adds Windows share target activation handling using MSIX packaging APIs
- Implements iOS and macOS share extension templates with Swift view controllers
- Creates a cross-platform listener system for real-time share events
- Adds new commands and APIs for retrieving and clearing pending shared content
Reviewed changes
Copilot reviewed 53 out of 64 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/windows.rs |
Implements Windows share target activation, handling both cold and warm start scenarios with app instance management |
src/models.rs |
Defines new data structures for shared content (text and files) with proper serialization |
src/listeners.rs |
Adds desktop listener infrastructure for event-driven share notifications |
src/mobile.rs, src/macos.rs, src/desktop.rs |
Adds cross-platform method stubs for pending content APIs |
src/commands.rs |
Exposes new Tauri commands for JavaScript consumption |
guest-js/index.ts |
Provides TypeScript API including getPendingSharedContent, clearPendingSharedContent, and onSharedContent listener |
| iOS/macOS templates | Complete share extension implementations handling various content types (text, URLs, files, images) |
| Example demo | Comprehensive demonstration with UI for displaying received content and logs |
| Build configs | Updates permissions, dependencies, and Xcode project configurations |
Files not reviewed (1)
- examples/share-demo/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # Cargo.toml # examples/share-demo/src/routes/+page.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.