feat(udf): allow different iginx nodes to have same udf when needInitBasicUDFFunctions is true#2
Open
ChihuaYing wants to merge 1 commit into
Open
feat(udf): allow different iginx nodes to have same udf when needInitBasicUDFFunctions is true#2ChihuaYing wants to merge 1 commit into
ChihuaYing wants to merge 1 commit into
Conversation
…asicUDFFunctions is true
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Enables multiple IginX nodes to share the same UDF name when needInitBasicUDFFunctions=true, avoiding unintended overwrites by appending the current node’s ip:port to the existing UDF metadata instead of replacing it.
Changes:
- Update existing UDF metadata (
taskMeta) by adding the current nodeip:portand persisting it, rather than updating with the newly createdmeta. - Ensures UDF metadata aggregation across nodes during basic UDF initialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
179
to
186
| if (taskMeta == null) { | ||
| metaManager.addPyFunction(meta); | ||
| } else if (!taskMeta.containsIpPort(config.getIp(), config.getPort())) { | ||
| meta.addIpPort(config.getIp(), config.getPort()); | ||
| metaManager.updatePyFunction(meta); | ||
| taskMeta.addIpPort(config.getIp(), config.getPort()); | ||
| metaManager.updatePyFunction(taskMeta); | ||
| } | ||
|
|
||
| if (!meta.getType().equals(UDFType.TRANSFORM)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
当配置文件的needInitBasicUDFFunctions为true时，原本逻辑下不同的iginx不能同时拥有同名的UDF（会覆盖），现在则支持。