Skip to content

feat: add MediaElement MVP control and initial tests#9

Open
lustsazeus-lab wants to merge 2 commits intoChevalier12:masterfrom
lustsazeus-lab:feat/media-element-mvp-issue5
Open

feat: add MediaElement MVP control and initial tests#9
lustsazeus-lab wants to merge 2 commits intoChevalier12:masterfrom
lustsazeus-lab:feat/media-element-mvp-issue5

Conversation

@lustsazeus-lab
Copy link

@lustsazeus-lab lustsazeus-lab commented Mar 10, 2026

Summary

  • add a new MediaElement control scaffold with dependency properties and playback state transitions
  • wire MediaElement into automation peer control-type mapping
  • add initial tests for null-source failure handling, deterministic state transitions, and XAML instantiation

Notes

  • this PR intentionally delivers the MVP control contract first so the LibVLC backend/distribution path can be layered incrementally
  • in this environment, dotnet is unavailable, so CI/local build confirmation should run in project CI or a .NET-enabled machine

Closes #5

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22f1794215

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +50 to +52
<MediaElement xmlns=\"urn:inkkslinger-ui\"
Source=\"https://example.com/demo.mp4\"
LoadedBehavior=\"Manual\" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove escaped quotes from raw XAML literal

This test uses a C# raw string ("""), so \" is emitted literally into the XML; that produces markup like xmlns=\"urn:inkkslinger-ui\", which is not well-formed and will fail in XamlLoader.LoadFromString when it calls XDocument.Parse. As written, XamlLoader_CanInstantiate_MediaElement will throw before assertions and won't validate MediaElement instantiation.

Useful? React with 👍 / 👎.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in commit 174b0a8 — removed escaped quotes in the C# raw string literal so the test now emits valid XML for XamlLoader.LoadFromString.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bounty: Implement MediaElement control (lifetime commercial license reward)

1 participant