This repository was archived by the owner on Mar 3, 2020. It is now read-only.
Open
Conversation
pattyssilveira
requested review from
beatriz1304,
dleitee,
douglasgimli,
mibsbalsante and
smaniotto
beatriz1304
reviewed
Aug 9, 2018
| import { Carousel } from 'react-responsive-carousel' | ||
| import 'react-responsive-carousel/lib/styles/carousel.min.css' | ||
|
|
||
| class Carrousel extends PureComponent { |
Contributor
There was a problem hiding this comment.
I think it's not necessary to use PureComponent
Contributor
There was a problem hiding this comment.
PureComponent can improve our page performance, so we should use it when is possible.
Contributor
There was a problem hiding this comment.
Also, I think this component should be stateless
beatriz1304
reviewed
Aug 9, 2018
| @@ -0,0 +1,3 @@ | |||
| :global { | |||
Contributor
There was a problem hiding this comment.
You're not applying any style here, I think you should remove that
dleitee
suggested changes
Aug 13, 2018
| import { Carousel } from 'react-responsive-carousel' | ||
| import 'react-responsive-carousel/lib/styles/carousel.min.css' | ||
|
|
||
| class Carrousel extends PureComponent { |
Contributor
There was a problem hiding this comment.
PureComponent can improve our page performance, so we should use it when is possible.
| return ( | ||
| <Carousel autoPlay width={size}> | ||
| {images.map(({ url, alt, legend }) => ( | ||
| <div> |
| {images.map(({ url, alt, legend }) => ( | ||
| <div> | ||
| <img src={url} alt={alt} /> | ||
| <p className="legend">{legend}</p> |
Contributor
There was a problem hiding this comment.
why are you not using css modules here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR: