Skip to content

Fix for #17 : Incorrect data encoded in json when numeric support is enabled #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minhaajk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for #17 : Incorrect data encoded in json when numeric support is enabled #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions include/xml2json.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,13 @@ static bool xml2json_has_digits_only(const char * input, bool *hasDecimal)
const char * runPtr = input;

*hasDecimal = false;


//Check for negative number
if (*runPtr == '-')
{
runPtr++;
}

while (*runPtr != '\0')
{
if (*runPtr == '.')
Expand All @@ -57,7 +63,7 @@ static bool xml2json_has_digits_only(const char * input, bool *hasDecimal)
else
return false; // we found two dots - not a number
}
else if (isalpha(*runPtr))
else if (!isdigit(*runPtr))
{
return false;
}
Expand Down