-
-
Notifications
You must be signed in to change notification settings - Fork 51
[Feature] delete conversations by sequence range #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dingyi222666
wants to merge
1
commit into
v1-dev
Choose a base branch
from
fix/delete-batch-889
base: v1-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+160
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -280,6 +280,18 @@ export function apply(ctx: Context, config: Config, chain: ChatChain) { | |
| try { | ||
| const { presetLane, includeArchived, allPresetLanes } = | ||
| getManageOptions(context) | ||
| const seqs = | ||
| context.options.conversation_manage?.targetConversationSeqs | ||
|
|
||
| if (seqs != null) { | ||
| context.message = await deleteBySeqs(ctx, session, seqs, { | ||
| presetLane, | ||
| includeArchived, | ||
| allPresetLanes | ||
| }) | ||
| return ChainMiddlewareRunStatus.STOP | ||
| } | ||
|
|
||
| const conversation = | ||
| await ctx.chatluna.conversation.deleteConversation(session, { | ||
| conversationId: resolvedConversationId(context), | ||
|
|
@@ -765,6 +777,36 @@ function getManageOptions(context: ChainMiddlewareContext) { | |
| } | ||
| } | ||
|
|
||
| async function deleteBySeqs( | ||
| ctx: Context, | ||
| session: Session, | ||
| seqs: number[], | ||
| opts: ReturnType<typeof getManageOptions> | ||
| ) { | ||
| const entries = await ctx.chatluna.conversation.listConversationEntries( | ||
| session, | ||
| opts | ||
| ) | ||
| const targets = entries.filter((item) => seqs.includes(item.displaySeq)) | ||
| if (targets.length !== seqs.length) { | ||
| return session.text('chatluna.conversation.messages.target_not_found') | ||
| } | ||
|
dingyi222666 marked this conversation as resolved.
|
||
|
|
||
| const deleted: ConversationRecord[] = [] | ||
| for (const target of targets) { | ||
| deleted.push( | ||
| await ctx.chatluna.conversation.deleteConversation(session, { | ||
| conversationId: target.conversation.id, | ||
| ...opts | ||
| }) | ||
| ) | ||
| } | ||
|
|
||
| return session.text('chatluna.conversation.messages.delete_success', [ | ||
| deleted.map((item) => item.title).join('\n') | ||
| ]) | ||
|
Comment on lines
+805
to
+807
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i18n 消息参数不一致 批量删除和单个删除使用同一个 i18n 键
如果 i18n 模板期望三个占位符(如 建议统一参数格式,或为批量删除使用独立的 i18n 键。 🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| function conversationSummary(conversation: ConversationRecord) { | ||
| return [ | ||
| conversation.title, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user runs a selector with a very large range, e.g.
chatluna.delete 1..1000000000, this loop expands every integer into aSetbefore the middleware ever checks which conversations exist. Becausechatluna.deleteis available at authority 1, a short command can block the bot's event loop and/or exhaust memory; validate the range size or defer expansion until after listing the available entries.Useful? React with 👍 / 👎.