fix: correct casing for site adapter display names#933
fix: correct casing for site adapter display names#933PeterDaveHello wants to merge 1 commit intoChatGPTBox-dev:masterfrom
Conversation
This adds a display name mapping to the SiteAdapters component to show proper capitalization (e.g., 'GitHub' instead of 'github') while preserving internal config keys. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user interface of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIntroduces user-friendly display names for site keys in the SiteAdapters component via a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
There was a problem hiding this comment.
Code Review
This pull request introduces a mapping to display properly capitalized names for site adapters in the UI, which is a nice enhancement for readability. The implementation is straightforward, using a map object and falling back to the original key if a display name isn't found. My main feedback is that the list of display names is incomplete, which would lead to an inconsistent UI. I've suggested completing the list for all supported site adapters.
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||
There was a problem hiding this comment.
Pull request overview
This PR improves the popup “Sites” (SiteAdapters) UI by rendering user-friendly, properly-capitalized site names (e.g., “GitHub”) while keeping the underlying configuration keys unchanged.
Changes:
- Add a
siteDisplayNamesmapping for known site adapter keys. - Render mapped display names in the SiteAdapters list, falling back to the raw key when no mapping exists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
User description
This adds a display name mapping to the SiteAdapters component to show proper capitalization (e.g., 'GitHub' instead of 'github') while preserving internal config keys.
PR Type
Bug fix, Enhancement
Description
Add display name mapping for site adapters with proper capitalization
Replace raw config keys with user-friendly display names in UI
Fallback to original key if display name not found
Diagram Walkthrough
File Walkthrough
SiteAdapters.jsx
Add display name mapping for site adapterssrc/popup/sections/SiteAdapters.jsx
siteDisplayNamesobject mapping 14 site adapter keys to properlycapitalized display names
siteDisplayNames[key] || keyfor fallbacksupport
'YouTube' instead of 'youtube', etc.
Summary by CodeRabbit