Skip to content

Pull request practice#5

Open
NitaraSen wants to merge 3 commits intoChase-Fournier:mainfrom
NitaraSen:main
Open

Pull request practice#5
NitaraSen wants to merge 3 commits intoChase-Fournier:mainfrom
NitaraSen:main

Conversation

@NitaraSen
Copy link
Copy Markdown

Pull Request Template/Instructions

Description

I added a png and my guess about what this project is about

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Other (please describe): pull request practice

Related Issues (put task name here from notion)

Pre-Submission Checklist

Code Review Preparation

  • I have performed a self-review and reviewed the changed files
  • My code follows the project's style guidelines and passes linting
  • I have added comments in hard-to-understand areas and updated documentation

Testing (Ignore for the first PR)

  • I have added relevant tests and they pass locally
  • I have tested the changes manually, including edge cases

Code Quality & Security

  • I have formatted my code and removed debugging/unused code
  • No TypeScript errors or linting issues
  • No sensitive information committed (API keys, passwords, etc.)
  • User inputs are validated and sanitized

Dependencies & Deployment

  • Dependencies are documented and package-lock.json is updated if needed
  • Changes work with Firebase emulator and environment variables are documentedRetry

Screenshots (If it is a front end feature screenshot is required)

Additional Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant