Skip to content

[FIX] Bug of getStatistics #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChanHHOO merged 1 commit into from
Oct 27, 2025
Merged

[FIX] Bug of getStatistics #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/main/kotlin/com/flo/nem12/handler/CompositeFailureHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,8 @@ class CompositeFailureHandler(
}

override fun getStatistics(): Map<FailureReason, Int> {
// Aggregate statistics from all handlers
val aggregated = mutableMapOf<FailureReason, Int>()

handlers.forEach { handler ->
handler.getStatistics().forEach { (reason, count) ->
aggregated[reason] = aggregated.getOrDefault(reason, 0) + count
}
}

return aggregated
// Return statistics from the first handler to avoid double counting
return handlers.firstOrNull()?.getStatistics() ?: emptyMap()
}

override fun close() {
Expand Down
8 changes: 4 additions & 4 deletions src/test/kotlin/com/flo/nem12/handler/CompositeFailureHandlerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class CompositeFailureHandlerTest {
}

@Test
fun `should aggregate statistics from multiple handlers`() {
fun `should return statistics from first handler`() {
// Given
val handler1 = LoggingFailureHandler()
val handler2 = LoggingFailureHandler()
Expand Down Expand Up @@ -65,10 +65,10 @@ class CompositeFailureHandlerTest {
compositeHandler.handleFailure(failure1)
compositeHandler.handleFailure(failure2)

// Then - Statistics should be aggregated from both handlers
// Then - Statistics should come from first handler only (to avoid double counting)
val stats = compositeHandler.getStatistics()
assertEquals(2, stats[FailureReason.NEGATIVE_VALUE]) // Each handler counted once
assertEquals(2, stats[FailureReason.EMPTY_VALUE])
assertEquals(1, stats[FailureReason.NEGATIVE_VALUE])
assertEquals(1, stats[FailureReason.EMPTY_VALUE])

// Clean up
compositeHandler.close()
Expand Down