fix: Issue with accordion requiring two clicks to close#2834
Open
Allaoua9 wants to merge 1 commit intoChainlit:mainfrom
Open
fix: Issue with accordion requiring two clicks to close#2834Allaoua9 wants to merge 1 commit intoChainlit:mainfrom
Allaoua9 wants to merge 1 commit intoChainlit:mainfrom
Conversation
Allaoua9
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
bot
added
size:XS
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accordion was not closing on the first click. it required two clicks to close.
This issue was that the controlled accordion was incorrectly handled.
Summary by cubic
Fixes the step accordion so it closes on the first click by standardizing the controlled value to a string. The closed state now uses
''instead ofundefined, andonValueChangesets the value directly, making user toggles and auto-collapse work reliably.Written for commit d3fbc94. Summary will update on new commits.