Skip to content

fix: show error toast when streamable-http MCP connection fails (fixes #2823) #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giulio-leone wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix: show error toast when streamable-http MCP connection fails (fixes #2823) #2829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion frontend/src/api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,18 @@ class ExtendedChainlitAPI extends ChainlitAPI {
...(headers ? { headers } : {})
})
}).then(async (res) => {
if (!res.ok) {
let detail: string | undefined;
try {
const data = await res.json();
detail = data.detail;
} catch {
// Response body is not JSON (e.g. proxy HTML error page)
}
throw new ClientError(detail || res.statusText, res.status);
}
const data = await res.json();
return { success: res.ok, mcp: data.mcp, error: data.detail };
return { success: true, mcp: data.mcp, error: undefined };
});
}
}
Expand Down
Loading