Include empty mapping keys#85
Open
GiovanniTorrisi-ChainSecurity wants to merge 6 commits intomainfrom
Open
Conversation
GiovanniTorrisi-ChainSecurity
force-pushed
the
34-mapping-with-empty-string
branch
from
2d842ac to
7e31421
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included empty-string mapping keys in the storage variables.
This was done by relaxing the SHA3 filter in
contract_state. Before, only byte sequences longer than 32 bytes were accepted as SHA3 input. However, empty-string mapping keys produce SHA3("" || slot), therefore yielding a hash input of exactly 32 bytes.If the stricter length check was necessary to filter out false positives, let me know.
Resolves #34.