Merged
Conversation
Collaborator
Author
|
DO NOT MERGE YET. The tests are finally passing. But the sneaky bug that caused them to fail needs to be clarified before merging. |
GiovanniTorrisi-ChainSecurity
force-pushed
the
28-early-quit-event-validation
branch
from
b970183 to
487bce9
Compare
Collaborator
Author
|
Hi! There are a lot of commits in this MR. I would merge this with a single commit with a short commit message, instead of including all the sub-commits in the commit message. |
stiefn
force-pushed
the
28-early-quit-event-validation
branch
2 times, most recently
from
26055ed to
2d56ebe
Compare
stiefn
force-pushed
the
28-early-quit-event-validation
branch
from
40a6f55 to
0724277
Compare
stiefn
approved these changes
Jan 23, 2026
| } else { | ||
| return Err(ValidationError::Invalid(message)); | ||
| } | ||
| if num_occurrences + seen_events.len() > num_occurrences_expected { |
Contributor
There was a problem hiding this comment.
this no longer checks if the number of occurrences is lower than the expected ones. if a dvf has been set up correctly, this should never happen but there are no guarantees that the dvfs are set up correctly. you can now create a dvf with an additional event that has not been emitted yet and it will validate in the future once it is emitted.
stiefn
reviewed
Jan 23, 2026
| current_from = current_to + 1; | ||
| } | ||
|
|
||
| if num_occurrences < num_occurrences_expected { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #28.
Added early quit logic to the event validation, querying events in blocks and early quitting if there is a mismatch.
Refactored the get_events function into two:
get_eth_events: queries for all events in the range [from_block, to_block]get_eth_events_paginated: splits the block range in blocks of at most config.max_blocks_per_event_query, and usesget_eth_eventsto query the events.