refactor: use slices.Contains to simplify code#4787
Open
shandongzhejiang wants to merge 1 commit intoChainSafe:developmentfrom
Open
refactor: use slices.Contains to simplify code#4787shandongzhejiang wants to merge 1 commit intoChainSafe:developmentfrom
shandongzhejiang wants to merge 1 commit intoChainSafe:developmentfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #4787 +/- ##
===============================================
+ Coverage 50.51% 51.16% +0.65%
===============================================
Files 230 395 +165
Lines 29006 54018 +25012
===============================================
+ Hits 14653 27641 +12988
- Misses 12856 23985 +11129
- Partials 1497 2392 +895 🚀 New features to boost your workflow:
|
haikoschol
requested changes
Jun 26, 2025
Signed-off-by: shandongzhejiang <shandongzhejiang@icloud.com>
f1fafac to
f5d01ea
Compare
Author
|
Sorry for deal it so late. Modified. Please review it when you have time. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues