Skip to content

fix: add cancellation or timeout to more free tokio::spawn tasks#7282

Open
hanabi1224 wants to merge 2 commits into
mainfrom
hm/handle-tokio-spawn-tasks
Open

fix: add cancellation or timeout to more free tokio::spawn tasks#7282
hanabi1224 wants to merge 2 commits into
mainfrom
hm/handle-tokio-spawn-tasks

Conversation

@hanabi1224

Copy link
Copy Markdown
Contributor

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8eddaa1a-f3f2-4068-8b25-d67233f28d53

📥 Commits

Reviewing files that changed from the base of the PR and between cd92ebf and e3f77f6.

📒 Files selected for processing (4)
  • src/chain_sync/chain_follower.rs
  • src/daemon/mod.rs
  • src/libp2p/service.rs
  • src/rpc/methods/chain.rs
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • filecoin-project/lotus (manual)
👮 Files not reviewed due to content moderation or server errors (4)
  • src/daemon/mod.rs
  • src/rpc/methods/chain.rs
  • src/chain_sync/chain_follower.rs
  • src/libp2p/service.rs

Warning

Walkthrough skipped

File diffs could not be summarized.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hm/handle-tokio-spawn-tasks
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch hm/handle-tokio-spawn-tasks

Comment @coderabbitai help to get the list of available commands.

@hanabi1224 hanabi1224 added the RPC requires calibnet RPC checks to run on CI label Jul 2, 2026
@hanabi1224 hanabi1224 marked this pull request as ready for review July 2, 2026 12:36
@hanabi1224 hanabi1224 requested a review from a team as a code owner July 2, 2026 12:36
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team July 2, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant